openAgent

1import fs from "fs/promises"
2import path from "path"
3import { describe, expect, test } from "bun:test"
4import { Effect, Layer } from "effect"
5import { HttpClient, HttpClientResponse } from "effect/unstable/http"
6import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder"
7import { LayerNodePlatform } from "@opencode-ai/core/effect/app-node-platform"
8import { LayerNode } from "@opencode-ai/core/effect/layer-node"
9import { Global } from "@opencode-ai/core/global"
10import { SkillDiscovery } from "@opencode-ai/core/skill/discovery"
11import { tmpdir } from "./fixture/tmpdir"
12 
13const base = "https://skills.example.test/catalog/"
14 
15async function pull(skills: unknown[], files: Record<string, string> = {}, cache?: Awaited<ReturnType<typeof tmpdir>>) {
16  const tmp = cache ?? (await tmpdir())
17  const requests: string[] = []
18  const http = Layer.succeed(
19    HttpClient.HttpClient,
20    HttpClient.make((request) =>
21      Effect.sync(() => requests.push(request.url)).pipe(
22        Effect.map(() => {
23          const body = request.url === `${base}index.json` ? JSON.stringify({ skills }) : files[request.url]
24          return HttpClientResponse.fromWeb(
25            request,
26            new Response(body ?? "Not Found", { status: body === undefined ? 404 : 200 }),
27          )
28        }),
29      ),
30    ),
31  )
32  const skillDiscoveryLayer = AppNodeBuilder.build(SkillDiscovery.node, [
33    [LayerNodePlatform.httpClient, http],
34    [Global.node, Global.layerWith({ cache: tmp.path })],
35  ])
36  const directories = await Effect.runPromise(
37    Effect.gen(function* () {
38      return yield* (yield* SkillDiscovery.Service).pull(base)
39    }).pipe(Effect.provide(skillDiscoveryLayer)),
40  )
41  return { tmp, requests, directories }
42}
43 
44describe("SkillDiscovery.pull", () => {
45  test("rejects skill name traversal without fetching files", async () => {
46    const result = await pull([{ name: "../outside", files: ["SKILL.md"] }])
47    try {
48      expect(result.directories).toEqual([])
49      expect(result.requests).toEqual([`${base}index.json`])
50      expect(await fs.readdir(result.tmp.path)).toEqual([])
51    } finally {
52      await result.tmp[Symbol.asyncDispose]()
53    }
54  })
55 
56  test("rejects file traversal without fetching files", async () => {
57    const result = await pull([{ name: "deploy", files: ["SKILL.md", "../outside.md"] }])
58    try {
59      expect(result.directories).toEqual([])
60      expect(result.requests).toEqual([`${base}index.json`])
61      expect(await fs.readdir(result.tmp.path)).toEqual([])
62    } finally {
63      await result.tmp[Symbol.asyncDispose]()
64    }
65  })
66 
67  test("rejects absolute file paths without fetching files", async () => {
68    const result = await pull([{ name: "deploy", files: ["SKILL.md", "/tmp/outside.md"] }])
69    try {
70      expect(result.directories).toEqual([])
71      expect(result.requests).toEqual([`${base}index.json`])
72      expect(await fs.readdir(result.tmp.path)).toEqual([])
73    } finally {
74      await result.tmp[Symbol.asyncDispose]()
75    }
76  })
77 
78  test("rejects cross-origin file URLs without fetching files", async () => {
79    const result = await pull([{ name: "deploy", files: ["SKILL.md", "https://evil.example.test/outside.md"] }])
80    try {
81      expect(result.directories).toEqual([])
82      expect(result.requests).toEqual([`${base}index.json`])
83      expect(await fs.readdir(result.tmp.path)).toEqual([])
84    } finally {
85      await result.tmp[Symbol.asyncDispose]()
86    }
87  })
88 
89  test("downloads safe nested files under the skill root", async () => {
90    const result = await pull([{ name: "deploy", files: ["SKILL.md", "references/guide.md"] }], {
91      [`${base}deploy/SKILL.md`]: "# Deploy",
92      [`${base}deploy/references/guide.md`]: "# Guide",
93    })
94    try {
95      expect(result.directories).toHaveLength(1)
96      expect(result.requests.toSorted()).toEqual(
97        [`${base}index.json`, `${base}deploy/SKILL.md`, `${base}deploy/references/guide.md`].toSorted(),
98      )
99      expect(await fs.readFile(path.join(result.directories[0], "SKILL.md"), "utf8")).toBe("# Deploy")
100      expect(await fs.readFile(path.join(result.directories[0], "references", "guide.md"), "utf8")).toBe("# Guide")
101    } finally {
102      await result.tmp[Symbol.asyncDispose]()
103    }
104  })
105 
106  test("refreshes cached files when the version changes", async () => {
107    const tmp = await tmpdir()
108    try {
109      const first = await pull(
110        [{ name: "deploy", version: "1", files: ["SKILL.md"] }],
111        {
112          [`${base}deploy/SKILL.md`]: "# Old",
113        },
114        tmp,
115      )
116      const second = await pull(
117        [{ name: "deploy", version: "2", files: ["SKILL.md"] }],
118        {
119          [`${base}deploy/SKILL.md`]: "# New",
120        },
121        tmp,
122      )
123 
124      expect(await fs.readFile(path.join(first.directories[0], "SKILL.md"), "utf8")).toBe("# New")
125      expect(second.requests).toContain(`${base}deploy/SKILL.md`)
126      const third = await pull(
127        [{ name: "deploy", version: "2", files: ["SKILL.md"] }],
128        { [`${base}deploy/SKILL.md`]: "# Ignored" },
129        tmp,
130      )
131      expect(third.requests).toEqual([`${base}index.json`])
132    } finally {
133      await tmp[Symbol.asyncDispose]()
134    }
135  })
136 
137  test("publishes complete updates and removes stale files", async () => {
138    const tmp = await tmpdir()
139    try {
140      const first = await pull(
141        [{ name: "deploy", version: "1", files: ["SKILL.md", "old.md"] }],
142        {
143          [`${base}deploy/SKILL.md`]: "# Old",
144          [`${base}deploy/old.md`]: "old reference",
145        },
146        tmp,
147      )
148      const root = first.directories[0]
149 
150      await pull(
151        [{ name: "deploy", version: "2", files: ["SKILL.md", "missing.md"] }],
152        { [`${base}deploy/SKILL.md`]: "# Partial" },
153        tmp,
154      )
155      expect(await fs.readFile(path.join(root, "SKILL.md"), "utf8")).toBe("# Old")
156      expect(await fs.readFile(path.join(root, "old.md"), "utf8")).toBe("old reference")
157 
158      await pull([{ name: "deploy", version: "3", files: ["SKILL.md"] }], { [`${base}deploy/SKILL.md`]: "# New" }, tmp)
159      expect(await fs.readFile(path.join(root, "SKILL.md"), "utf8")).toBe("# New")
160      expect(await Bun.file(path.join(root, "old.md")).exists()).toBe(false)
161    } finally {
162      await tmp[Symbol.asyncDispose]()
163    }
164  })
165})
166